From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 18 Oct 2018 21:53:51 GMT
Subject: Re: [PATCH] send-email: explicitly disable authentication
Message-ID: <CAPig+cR27mPmH+0oeT+2T878K-cBNqBnxPUumETnVK1cvz2qnA@mail.gmail.com>
In-Reply-To: <20181018211527.25597-1-JPEWhacker@gmail.com>

On Thu, Oct 18, 2018 at 5:16 PM Joshua Watt <jpewhacker@gmail.com> wrote:
> It can be necessary to disable SMTP authentication by a mechanism other
> than sendemail.smtpuser being undefined. For example, if the user has
> sendemail.smtpuser set globally but wants to disable authentication
> locally in one repository.
>
> --smtp-auth and sendemail.smtpauth now understand the value 'none' which
> means to disable authentication completely, even if an authentication
> user is specified.

Implementation complexity aside, spelling the option --no-smtp-auth
might be more intuitive and consistent than --smtp-auth=none.

> The value 'none' is lower case to avoid conflicts with any RFC 4422
> authentication mechanisms.
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>