From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 01 Feb 2024 15:00:41 GMT
Subject: Re: [PATCH 1/7] reftable/record: introduce function to compare records by key
Message-ID: <CAPig+cR0iMPQWeTjC3RVnJFydGL6ZNdV3O63uC84VJ+TJhv_Ew@mail.gmail.com>
In-Reply-To: <fadabec696f75ae0fa25bcbf87012fcc4768acaa.1706782841.git.ps@pks.im>

On Thu, Feb 1, 2024 at 8:31 AM Patrick Steinhardt <ps@pks.im> wrote:
> In some places we need to sort reftable records by their keys to
> determine their ordering. This is done by first formatting the keys into
> a `struct strbuf` and then using `strbuf_cmp()` to compare them. This
> logic is needlessly roundabout and can end up costing quite a bit fo CPU
> cycles, both due to the allocation and formatting logic.

s/fo/of/

> Introduce a new `reftable_record_cmp()` function that knows to compare
> two records with each other without requiring allocations.

perhaps: s/knows to compare/knows how to compare/

> Signed-off-by: Patrick Steinhardt <ps@pks.im>