From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 28 May 2015 18:35:22 GMT
Subject: Re: [PATCH 2/2] commit: fix ending newline for template files
Message-ID: <CAPig+cR=Mrgb+-ZZcM6m7AcL25gXYtmEVpO3c23k_UKXPgyQnA@mail.gmail.com>
In-Reply-To: <xmqqpp5kh8a0.fsf@gitster.dls.corp.google.com>

On Thu, May 28, 2015 at 2:22 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> Moreover, it lacks justification and explanation of why you consider
>> the cleanup unnecessary. History [1] indicates that its application to
>> -F but not -t was intentional.
>>
>> [1]: bc92377 (commit: fix ending newline for template files, 2015-05-26)
>
> Sorry, but the date of that commit seems to be too new to be
> considered "history"; I do not seem to have it, either.

Indeed, I somehow botched that. I meant: 8b1ae67 (Do not strip empty
lines / trailing spaces from a commit message template, 2011-05-08)

> But I agree with you that I too failed to see why this change is
> necessary or desirable in the explanation in the proposed log
> message.