From: Eric Sunshine Date: Sun, 10 Apr 2016 21:51:06 GMT Subject: Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris Message-ID: In-Reply-To: On Sun, Apr 10, 2016 at 3:01 PM, Junio C Hamano wrote: > Subject: t1020: do not overuse printf and use write_script > > The test prepares a sample file "dir/two" with a single incomplete > line in it with "printf", and also prepares a small helper script > "diff" to create a file with a single incomplete line in it, again > with "printf". The output from the latter is compared with an > expected output, again prepared with "printf" hance lacking the s/hance/hence/ > final LF. There is no reason for this test to be using files with > an incomplete line at the end, and these look more like a mistake > of not using > > printf "%s\n" "string to be written" > > and using > > printf "string to be written" > > Depending on what would be in $GIT_PREFIX, using the latter form > could be a bug waiting to happen. Correct them. > > Also, the test uses hardcoded #!/bin/sh to create a small helper > script. For a small task like what the generated script does, it > does not matter too much in that what appears as /bin/sh would not > be _so_ broken, but while we are at it, use write_script instead, > which happens to make the result easier to read by reducing need > of one level of quoting. > > Signed-off-by: Junio C Hamano