From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 20 Mar 2013 19:12:07 GMT
Subject: Re: [PATCH v2] index-pack: always zero-initialize object_entry list
Message-ID: <CAPig+cQobu8GoqSNjVw8498e8D3vEJKU+UVUqkYbwypLyPTNhQ@mail.gmail.com>
In-Reply-To: <20130319161722.GA17445@sigill.intra.peff.net>

On Tue, Mar 19, 2013 at 12:17 PM, Jeff King <peff@peff.net> wrote:
> To ensure that all depths start at 0, that commit changed
> calls to xmalloc the object_entry list into calls to
> xcalloc.  However, it forgot that we grow the list with
> xrealloc later. These extra entries are used when we add an
> object from elsewhere pack to complete a thin pack. If we

s/elsewhere pack/pack/

> add a non-delta object, its depth value will just be
> uninitialized heap data.