From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 23 Apr 2018 06:07:55 GMT
Subject: Re: [PATCH v3 6/6] help: use command-list.txt for the source of guides
Message-ID: <CAPig+cQnmpR_WGZqb+A8zoH3D60VeJ0CWZkR0hXA_fgJSjWLUQ@mail.gmail.com>
In-Reply-To: <20180421165414.30051-7-pclouds@gmail.com>

On Sat, Apr 21, 2018 at 12:54 PM, Nguyễn Thái Ngọc Duy
<pclouds@gmail.com> wrote:
> The help command currently hard codes the list of guides and their
> summary in C. Let's move this list to command-list.txt. This lets us
> extract summary lines from Documentation/git*.txt. This also
> potentially lets us lists guides in git.txt, but I'll leave that for
> now.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
> @@ -58,7 +58,11 @@ command_list "$1" |
>  do
> -       prefix=git-
> +       if [ "$category" = guide ]; then

Style:

    if test "$category" = guide
    then
        ...

> +               prefix=git
> +       else
> +               prefix=git-
> +       fi