From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 28 Aug 2015 00:16:35 GMT
Subject: Re: [PATCH] stash: Add stash.showFlag config variable
Message-ID: <CAPig+cQmTS5rRkfh1in9qR4MyP1_y9vNar7U4H3uayK6Vixa7w@mail.gmail.com>
In-Reply-To: <CAM9d7chUf=srU060Q4+qQ4mFBaXmRL0yQ1Ns4UeWcDj62CFoYg@mail.gmail.com>

On Thu, Aug 27, 2015 at 11:36 AM, Namhyung Kim <namhyung@gmail.com> wrote:
> On Fri, Aug 28, 2015 at 12:20 AM, SZEDER Gábor <szeder@ira.uka.de> wrote:
>>  - This hunk runs the the exact same 'git config' command twice.  Run it
>>    only once, perhaps something like this:
>>
>>      show_flag=$(git config --get stash.showflag || echo --stat)
>>
>>    (I hope there are no obscure crazy 'echo' implemtations out there
>>    that might barf on the unknown option '--stat'...)
>
> What about `echo "--stat"` then?

Adding quotes around --stat won't buy you anything since the shell
will have removed the quotes by the time the argument is passed to
echo, so an "obscure crazy" 'echo' will still see --stat as an option.

POSIX states that printf should take no options, so:

    printf --stat

should be safe, but some implementations do process options (and will
complain about the unknown --stat option), therefore, best would be:

    printf '%s' --stat