From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 04 Jun 2021 18:10:08 GMT
Subject: Re: [PATCH 3/3] cmake: add warning for ignored MSGFMT_EXE
Message-ID: <CAPig+cQkR2LRmgHDz13-Cc0ohihJgsRAjGMnMagSbKh5QHLL5A@mail.gmail.com>
In-Reply-To: <07763a9de723af8674b707ba762845fd414bd0a6.1622828605.git.gitgitgadget@gmail.com>

On Fri, Jun 4, 2021 at 1:44 PM Matthew Rogers via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> It does not make sense to attempt to set MSGFMT_EXE when NO_GETTEXT is
> configured, as such add a check for NO_GETTEXT before attempting to set
> it.

This would be easier to digest if "as such" is the start of a new
sentence: "As such...". Or "Therefore, add a check...".

> suggested-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Matthew Rogers <mattr94@gmail.com>

s/suggested-by/Suggested-by:/

Tiny little nits, both. Don't know if it's worth a re-roll, but if you
happen to re-roll for some other reason, perhaps these could be
tweaked.