From: Eric Sunshine Date: Fri, 17 Jun 2016 23:31:07 GMT Subject: Re: [PATCH 4/7] run-command: add pipe_command helper Message-ID: In-Reply-To: <20160617232857.GA26564@sigill.intra.peff.net> On Fri, Jun 17, 2016 at 7:28 PM, Jeff King wrote: > On Fri, Jun 17, 2016 at 04:03:18PM -0400, Eric Sunshine wrote: >> > diff --git a/run-command.h b/run-command.h >> > @@ -79,17 +79,34 @@ int run_command_v_opt(const char **argv, int opt); >> > /** >> > - * Execute the given command, capturing its stdout in the given strbuf. >> > + * Execute the given command, sending "in" to its stdin, and capturing its >> > + * stdout and stderr in the "out" and "err" strbufs. Any of the three may >> > + * be NULL to skip processing. >> > + * >> > * Returns -1 if starting the command fails or reading fails, and otherwise >> > - * returns the exit code of the command. The output collected in the >> > - * buffer is kept even if the command returns a non-zero exit. The hint field >> > - * gives a starting size for the strbuf allocation. >> > + * returns the exit code of the command. Any output collected in the >> >> Did you mean s/returns/Returns/ ? > > I don't think so. This is a continuatino of "...and otherwise" from the > context line above. Indeed. I somehow imagined a leading '-' on the line containing "...and otherwise".