From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 12 Jan 2022 19:46:43 GMT
Subject: Re: [PATCH 16/20] git-p4: tidied visual indented lines of conditionals
Message-ID: <CAPig+cQifriYb9mid2em18yuyPmpDvtROtRFC=Gq6=+sE+CBtw@mail.gmail.com>
In-Reply-To: <20220112134635.177877-17-jholdsworth@nvidia.com>

On Wed, Jan 12, 2022 at 8:47 AM Joel Holdsworth <jholdsworth@nvidia.com> wrote:
> git-p4: tidied visual indented lines of conditionals

Perhaps:

    git-p4: normalize indentation of lines in conditionals

or something. (Probably not worth a re-roll.)


> PEP8 recommends that when wrapping the arguments of conditional
> statements, an extra level of indentation should be added to distinguish
> arguments from the body of the statement.
>
> This guideline is described here:
> https://www.python.org/dev/peps/pep-0008/#indentation
>
> This patch either adds the indentation, or removes unnecessary wrapping.
>
> Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>