From: Eric Sunshine Date: Thu, 21 Mar 2024 04:55:20 GMT Subject: Re: [PATCH v4 3/4] t1300: add more tests for whitespace and inline comments Message-ID: In-Reply-To: <688128d8ef09589712634888074ffd71a192a7aa.1710994548.git.dsimic@manjaro.org> On Thu, Mar 21, 2024 at 12:17 AM Dragan Simic wrote: > Add a handful of additional tests, to improve the coverage of the handling > of configuration file entries whose values contain internal whitespace, > leading and/or trailing whitespace, which may or may not be enclosed within > quotation marks, or which contain an additional inline comment. > > At the same time, rework one already existing whitespace-related test a bit, > to ensure its consistency with the newly added tests. This change introduced > no functional changes to the already existing test. > > Helped-by: Eric Sunshine > Helped-by: Junio C Hamano > Signed-off-by: Dragan Simic > --- > diff --git a/t/t1300-config.sh b/t/t1300-config.sh > @@ -11,6 +11,98 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > +test_expect_success 'setup whitespace config' ' > + sed -e "s/^|//" \ > + -e "s/[$]$//" \ > + -e "s/X/\\t/g" >.git/config <<-\EOF Representing TAB as `\t` in the sed replacement is not necessarily portable and (as far as I can see) we don't rely upon that in any existing tests. It probably would be safer to employ a literal TAB character in `s/X/ /g` as Junio showed in his example[1]. [1]: https://lore.kernel.org/git/xmqqzfutjtfo.fsf@gitster.g/