From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 30 Jun 2020 21:59:17 GMT
Subject: Re: [PATCH 5/5] test-lib-functions: restrict test_must_fail usage
Message-ID: <CAPig+cQdqYkCW7UED+sn+P-is+tDDGtY-KConhgJZW=CCHAk9A@mail.gmail.com>
In-Reply-To: <CAPig+cSNK1MDitZyh7Ax-eRAh6NjG_QsoF0feEo4475GjZ5ezw@mail.gmail.com>

On Tue, Jun 30, 2020 at 4:56 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Jun 30, 2020 at 11:03 AM Denton Liu <liu.denton@gmail.com> wrote:
> > +                       case "$1" in *?=*) ;; *) break ;; esac
>
> Isn't '*?=*' the same as '?=', or am I misunderstanding the intention?

Nevermind. My brain blipped out while reading that. Obviously '?=' is
not the same as '*?=*' here.

The rest of the review comments still stand (I think).