From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 01 Apr 2020 19:36:42 GMT
Subject: Re: [PATCH] commit-graph: fix buggy --expire-time option
Message-ID: <CAPig+cQc+Qr=BHKgWkQv8QrB47qG+-Y0+DQeKj5WD6VwzeAyHw@mail.gmail.com>
In-Reply-To: <20200401192715.GB13599@syl.local>

On Wed, Apr 1, 2020 at 3:27 PM Taylor Blau <me@ttaylorr.com> wrote:
> On Wed, Apr 01, 2020 at 06:11:35PM +0000, Derrick Stolee via GitGitGadget wrote:
> > -             git commit-graph write --reachable --split --size-multiple=10 --expire-time=1980-01-01 &&
> > +             touch -m -t 201801010000.00 $graphdir/extra.graph &&
> > +             git commit-graph write --reachable --split --size-multiple=10 --expire-time=2019-01-01 &&
>
> Could this be written instead as:
>
>   touch -m -t $(date -r $test_tick +"%Y%m%d%H%M.%S") $graphdir/extra.graph &&
>   test_tick &&

This won't work with GNU 'date' command which doesn't understand
"-r<number>" (it understands only "-r<reference-file>").