From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 30 Apr 2018 02:53:06 GMT
Subject: Re: [PATCH 6/6] Convert remaining die*(BUG) messages
Message-ID: <CAPig+cQbze2cZ9bsDC0o+es2j+E7a5qb30xgzT-m7ZNkpMuRDA@mail.gmail.com>
In-Reply-To: <0e85c7a16e3767eb03cdce0a7ed75a0c2b77d7d5.1525040254.git.johannes.schindelin@gmx.de>

On Sun, Apr 29, 2018 at 6:19 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> These were not caught by the previous commit, as they did not match the
> regular expression.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> diff --git a/submodule.c b/submodule.c
> @@ -2043,7 +2043,7 @@ const char *get_superproject_working_tree(void)
>                 if (super_sub_len > cwd_len ||
>                     strcmp(&cwd[cwd_len - super_sub_len], super_sub))
> -                       die (_("BUG: returned path string doesn't match cwd?"));
> +                       BUG("returned path string doesn't match cwd?");

This message used to be localizable but no longer is, which makes
sense since it's not intended as a user-facing error message but
rather is meant for Git developers. Good.