From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 10 Mar 2016 23:21:44 GMT
Subject: Re: [PATCH] t/t7502-commit.sh : remove a repeated test
Message-ID: <CAPig+cQbT3R_t=OfaueYZe2YQEdDbZWtyUFf-k=2_5S6vJuyMw@mail.gmail.com>
In-Reply-To: <0102015362ba5bb6-8212f758-f2fa-4272-8337-1cc669e7e8f4-000000@eu-west-1.amazonses.com>

On Thu, Mar 10, 2016 at 5:51 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
> t/t7502-commit.sh : remove a repeated test

Or:

    t7502: drop duplicate test

> This extra test was introducted in the commit f9c01817

We normally add some parenthetical context when mentioning commits:

    This extra test was introduced erroneously by
    f9c0181 (t7502: test commit.status, --status and
    --no-status, 2010-01-13)

The patch itself makes sense. Thanks.

> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
> ---
>  t/t7502-commit.sh | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
> index b39e313..725687d 100755
> --- a/t/t7502-commit.sh
> +++ b/t/t7502-commit.sh
> @@ -527,11 +527,6 @@ try_commit_status_combo () {
>                 test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>         '
>
> -       test_expect_success 'commit' '
> -               try_commit "" &&
> -               test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
> -       '
> -
>         test_expect_success 'commit --status' '
>                 try_commit --status &&
>                 test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
>
> --