From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 07 Jan 2018 00:29:26 GMT
Subject: Re: [PATCH 1/8] Doc/gitsubmodules: split a sentence for better readability
Message-ID: <CAPig+cQb1G0H5FS9bMmrqv=T45XoRwp2-2vUAEDayd0hV8PwYA@mail.gmail.com>
In-Reply-To: <20180106184614.20115-2-kaartic.sivaraam@gmail.com>

On Sat, Jan 6, 2018 at 1:46 PM, Kaartic Sivaraam
<kaartic.sivaraam@gmail.com> wrote:
> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
> ---
> diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt
> @@ -36,8 +36,8 @@ The `gitlink` entry contains the object name of the commit that the
>  The section `submodule.foo.*` in the `.gitmodules` file gives additional
> -hints to Gits porcelain layer such as where to obtain the submodule via
> -the `submodule.foo.url` setting.
> +hints to Gits porcelain layer. For example, the `submodule.foo.url`
> +setting specifies where to obtain the submodule.

I don't find the original difficult to read (aside, perhaps, from the
missing comma before "such as"), so I don't feel strongly about this
change.

However, since you're touching this, you could apply the s/Gits/Git's/ fix.