From: Eric Sunshine Date: Thu, 30 May 2013 10:09:42 GMT Subject: Re: [PATCH] wildmatch: properly fold case everywhere Message-ID: In-Reply-To: On Thu, May 30, 2013 at 5:29 AM, Anthony Ramine wrote: > Yes indeed. Will amend. Should I add your name in Reviewed-by as well? No. I merely spotted a minor typographical error. > -- > Anthony Ramine > > Le 30 mai 2013 à 11:07, Eric Sunshine a écrit : > >> On Thu, May 30, 2013 at 4:45 AM, Anthony Ramine wrote: >>> Case folding is not done correctly when matching against the [:upper:] >>> character class and uppercased character ranges (e.g. A-Z). >>> Specifically, an uppercase letter fails to match against any of them >>> when case folding is requested because plain characters in the pattern >>> and the whole string and preemptively lowercased to handle the base case >> >> Did you mean s/and preemptively/are preemptively/ ? >> >>> fast. >>> >>> That optimization is kept and ISLOWER() is used in the [:upper:] case >>> when case folding is requested, while matching against a character range >>> is retried with toupper() if the character was lowercase, as the bounds >>> of the range itself cannot be modified (in a case-insensitive context, >>> [A-_] is not equivalent to [a-_]). >>> >>> Signed-off-by: Anthony Ramine >