From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 31 Jul 2025 20:14:09 GMT
Subject: Re: [PATCH 6/9] notes: do not use strbuf_split*()
Message-ID: <CAPig+cQVo9diuwxqJZ-ippc65B2e_aFq6vEVZ2j-8ZYrVByZ9A@mail.gmail.com>
In-Reply-To: <20250731074154.2835370-7-gitster@pobox.com>

On Thu, Jul 31, 2025 at 3:42 AM Junio C Hamano <gitster@pobox.com> wrote:
> When reading the copy instruction from the standard input, the
> program reads a line, splits it into tokens at whitespace, and trims
> each of the tokens before using.  We no longer need to use strbuf
> just to be able to trimming, as string_list_split*() family now can
> trim while splitting a string.

s/trimming/trim/

> Retire the use of strbuf_split().
>
> Note that this loop is a bit sloppy in that it ensures at least
> there are two tokens on each line, but ignores if there are extra
> tokens on the line.  Tightening it is outside the scope of this
> series.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>