From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 26 Jul 2015 04:08:40 GMT
Subject: Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left
Message-ID: <CAPig+cQSy6imD_z+a9tvprJtn2-20awLJOcUQAksyv6HceVzxQ@mail.gmail.com>
In-Reply-To: <1437764685-8633-2-git-send-email-Karthik.188@gmail.com>

On Fri, Jul 24, 2015 at 3:04 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
> Add a new atom "align" and support %(align:X) where X is a number.
> This will align the preceeding atom value to the left followed by

Do you mean "succeeding" or "following" or "next" (or something)
rather than "preceding"?

> spaces for a total length of X characters. If X is less than the item
> size, the entire atom value is printed.

Isn't this a pad-right operation? If so, should this be called
%(padright:X) or %(pad:right:X)?

> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

Also, it is helpful to reviewers if you include an interdiff at the
bottom of your cover letter showing the changes from one version to
another. You can generate an interdiff with "git diff branchname-v4
branchname-v5", for instance.