From: Eric Sunshine <ericsunshine@gmail.com>
Date: Sat, 03 Dec 2022 05:14:59 GMT
Subject: Re: [PATCH v5 02/15] cmake: use "-S" and "-B" to specify source and build directories
Message-ID: <CAPig+cQRFtFWesYgaBfeqbP4Nax+-335W9at6uPgvCdtX_CPSQ@mail.gmail.com>
In-Reply-To: <patch-v5-02.15-314c5e40cff-20221202T110947Z-avarab@gmail.com>

On Fri, Dec 2, 2022 at 6:28 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> Rather than the multi-line "mkdir/cd/cmake" recipe provide an
> equivalent one-liner using the "-S" and "-B" options, and then suggest building with "make -C <build-dir>".
>
> The rest of these instructions discuss e.g. running tests from our
> top-level "t/" directory, so it's more helpful to avoid changing the
> user's current directory.
>
> The "-S" and "-B" options were added in cmake v3.13.0, which is older
> than the version we have a hard dependency on[1].
>
> As an aside The "-p" flag to "mkdir" in the pre-image wasn't needed,
> as "contrib/buildsystems" is tracked

s/aside The/aside, the/

> 1. 061c2240b1b (Introduce CMake support for configuring Git, 2020-06-12)
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>