From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 21 Feb 2016 23:40:04 GMT
Subject: Re: [PATCH 1/2] t8005: avoid grep on non-ASCII data
Message-ID: <CAPig+cQQWAsd9MB4yUKaFePdVoJqrqWEZCFakQxTiWKJWW+4cw@mail.gmail.com>
In-Reply-To: <xmqqsi0l8wt8.fsf@gitster.mtv.corp.google.com>

On Sun, Feb 21, 2016 at 6:31 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> These tests all crash and burn with BSD sed (including Mac OS X) since
>> you're not restricting yourself to BRE (basic regular expressions).
>> You _could_ request extended regular expressions, which do work on
>> those platforms, as well as with GNU sed:
>>
>>     sed -nEe "/^(author|summary) /p" ...
>
> An obvious way to avoid any RE is to write it as two separate
> statements.

Yes, that's even better; now I feel stupid for not thinking of it.