From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 09 Apr 2015 19:45:29 GMT
Subject: Re: [PATCH] grep: correctly initialize help-all option
Message-ID: <CAPig+cQQVO0RqZrAkLxS3v-iPf4LFsDOVz_fPDhofvLvs7tFyA@mail.gmail.com>
In-Reply-To: <1428586916-22679-1-git-send-email-ps@pks.im>

On Thu, Apr 9, 2015 at 9:41 AM, Patrick Steinhardt <ps@pks.im> wrote:
> The "help-all" option is being initialized with a wrong value.
> While being semantically wrong this can also cause a gcc
> segmentation fault on ARMv7 hardfloat platforms with a hardened
> toolchain. Fix this by initializing with the correct value.

Missing sign-off.

> ---
> diff --git a/builtin/grep.c b/builtin/grep.c
> index abc4400..c0bf005 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -738,7 +738,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
>                         PARSE_OPT_OPTARG, NULL, (intptr_t)default_pager },
>                 OPT_BOOL(0, "ext-grep", &external_grep_allowed__ignored,
>                          N_("allow calling of grep(1) (ignored by this build)")),
> -               { OPTION_CALLBACK, 0, "help-all", &options, NULL, N_("show usage"),
> +               { OPTION_CALLBACK, 0, "help-all", &opt, NULL, N_("show usage"),

This dates back to 3e230fa1 (grep: use parseopt; 2009-05-07).

builtin/show-ref.c just passes NULL for that argument in the same situation.

>                   PARSE_OPT_HIDDEN | PARSE_OPT_NOARG, help_callback },
>                 OPT_END()
>         };
> --
> 2.3.5