From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 14 Aug 2020 20:39:43 GMT
Subject: Re: [PATCH 1/3] t/README: document GIT_TEST_DEFAULT_HASH
Message-ID: <CAPig+cQLR1=6W-Y1y1XiWg1pC9FKikpqVsMrDKeK=exLJFDgLg@mail.gmail.com>
In-Reply-To: <242a44b63c8fc0ab7e8d8a6a913fde71444f931d.1597428440.git.gitgitgadget@gmail.com>

On Fri, Aug 14, 2020 at 2:07 PM Derrick Stolee via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> diff --git a/t/README b/t/README
> @@ -421,6 +421,9 @@ GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS=<boolean>, when true> +GIT_TEST_DEFAULT_HASH=<sha1|sha256> specifies which hash algorithm to use
> +in the test scripts.

Nit: The documentation for all the other environment variables has the
form `GIT_VAR=<generic-value-indicator>` rather than placing the
possible literal values within the angle brackets. So, perhaps this
can be written as:

    GIT_TEST_DEFAULT_HASH=<hash-algo> specifies which hash algorithm
    to use in the test scripts. Recognized values for <hash-algo> are
    "sha1" and "sha256".