From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 03 Jun 2018 08:32:52 GMT
Subject: Re: [PATCH 22/22] transport-helper.c: mark more strings for translation
Message-ID: <CAPig+cQKoF9EGMONWBxn6dKibTxuKcNeLH_3n+_=wYOrugK1KQ@mail.gmail.com>
In-Reply-To: <20180602043241.9941-23-pclouds@gmail.com>

On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> @@ -196,13 +196,13 @@ static struct child_process *get_helper(struct transport *transport)
> -                       die("Unknown mandatory capability %s. This remote "
> -                           "helper probably needs newer version of Git.",
> +                       die(_("Unknown mandatory capability %s. This remote "
> +                             "helper probably needs newer version of Git."),
>                             capname);

Did you want to downcase these and drop period for consistency with
others? Perhaps:

    unknown mandatory capability '%s'; this remote
    helper probably needs newer version of Git