From: Eric Sunshine Date: Fri, 20 Oct 2023 17:30:05 GMT Subject: Re: [PATCH 3/3] send-email: handle to/cc/bcc from --compose message Message-ID: In-Reply-To: <20231020101524.GA2673857@coredump.intra.peff.net> On Fri, Oct 20, 2023 at 6:15 AM Jeff King wrote: > If the user writes a message via --compose, send-email will pick up > varius headers like "From", "Subject", etc and use them for other s/varius/various/ > patches as if they were specified on the command-line. But we don't > handle "To", "Cc", or "Bcc" this way; we just tell the user "those > aren't interpeted yet" and ignore them. > > But it seems like an obvious thing to want, especially as the same > feature exists when the cover letter is generated separately by > format-patch. There it is gated behind the --to-cover option, but I > don't think we'd need the same control here; since we generate the > --compose template ourselves based on the existing input, if the user > leaves the lines unchanged then the behavior remains the same. > > So let's fill in the implementation; like those other headers we already > handle, we just need to assign to the initial_* variables. The only > difference in this case is that they are arrays, so we'll feed them > through parse_address_line() to split them (just like we would when > reading a single string via prompting). > > Signed-off-by: Jeff King