From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 24 Oct 2023 18:02:17 GMT
Subject: Re: [PATCH 04/12] builtin/show-ref: fix dead code when passing patterns
Message-ID: <CAPig+cQH4cV1KnwUWjFz-dRn1dQ9OWdmwaUpTMSjYwJGtnX5Gg@mail.gmail.com>
In-Reply-To: <29c0c0c6c9728f286efd0b78996f9a1394957862.1698152926.git.ps@pks.im>

On Tue, Oct 24, 2023 at 9:10 AM Patrick Steinhardt <ps@pks.im> wrote:
> When passing patterns to `git show-ref` we have some code that will
> cause us to die of `verify && !quiet` is true. But because `verify`

s/of/if/

> indicates a different subcommand of git-show-ref(1) that causes us to
> execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the
> condition cannot ever be true.
>
> Let's remove this dead code.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>