From: Eric Sunshine Date: Mon, 24 Feb 2020 09:19:54 GMT Subject: Re: [PATCH 1/2] t3400: make test clean up after itself Message-ID: In-Reply-To: <20200223101407.77036-2-sunshine@sunshineco.com> On Sun, Feb 23, 2020 at 5:15 AM Eric Sunshine wrote: > This test intentionally creates a file which causes rebase to fail, thus > it is important that this file be deleted before subsequent tests are > run which are not expecting such a failure. In the past, the common way > to ensure cleanup (regardless of whether the test succeeded or failed) > was either for the next test to perform the previous test's cleanup as > its first step or to do the cleanup at global scope outside of any > tests. With the introduction of 'test_when_finished', however, tests can > be responsible for their own cleanup. Therefore, update this test to > clean up after itself. > > A bit of history: This 'rm' invocation was moved from within the body of > the following test to global scope by bffd750adf (rebase: improve error > message when upstream argument is missing, 2010-05-31), which postdates, > by about a month, introduction of 'test_when_finished' in 3bf7886705 > (test-lib: Let tests specify commands to be run at end of test, > 2010-05-02). > --- Missing sign-off, so here it is: Signed-off-by: Eric Sunshine