From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 25 Mar 2018 00:40:12 GMT
Subject: Re: [PATCH v2] Makefile: detect compiler and enable more warnings in DEVELOPER=1
Message-ID: <CAPig+cQAufB=DDgkSwz+EDkkTKEx32KJBGPdeDxuzZTdoM2Nrg@mail.gmail.com>
In-Reply-To: <20180324125348.6614-1-pclouds@gmail.com>

On Sat, Mar 24, 2018 at 8:53 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> The set of extra warnings we enable when DEVELOPER has to be
> conservative because we can't assume any compiler version the
> developer may use. Detect the compiler version so we know when it's
> safe to enable -Wextra and maybe more.
>
> These warning settings are mostly from my custom config.mak a long
> time ago when I tried to enable as many warnings as possible that can
> still build without showing warnings. Some of them those warnings are

s/them those/those/

> probably worth fixing instead of just suppressing in future.
>
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>