From: Eric Sunshine Date: Tue, 24 Nov 2020 02:59:14 GMT Subject: Re: [PATCH v4 0/4] Maintenance IV: Platform-specific background maintenance Message-ID: In-Reply-To: <80762efd-c71b-4485-a2bb-f0577d90ff48@gmail.com> On Mon, Nov 23, 2020 at 9:20 PM Derrick Stolee wrote: > I was giving your 'test-tool getuid' idea a try, and found that _also_ > the $HOME environment variable differs from the format we expect in these > subcommands: > > $HOME: C:\... > argument in subcommand: /c/... Where does this problem crop up exactly? Is the test doing a literal comparison against the value in $HOME? > So, there is another reason why these tests don't work on Windows. I'm > of the opinion that maybe it's not worth _that_ level of cross-platform > testing. > > Unless I'm missing something simple about a $HOME alternative here, this > seems to be more work than the resulting value. Personally, I'm happy > with the benefit you've already provided in allowing Linux to test all > platforms. Indeed, it's not worth investing a lot of additional time into it. And it's certainly not a good reason to hold up the series. Moreover, this is the sort of thing which can be refined/handled later if someone wants to take a shot at it.