From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 25 Oct 2021 16:39:07 GMT
Subject: Re: [PATCH v4] archive: describe compression level option
Message-ID: <CAPig+cQ8NEKY3nwuFi_7Hc7L7rnbcUShf3zw60PvBB8LOPEgPA@mail.gmail.com>
In-Reply-To: <xmqqcznvbg2m.fsf@gitster.g>

On Sat, Oct 23, 2021 at 5:13 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> >> +-<digit>::
> >> +       Regulate compression level using the specified <digit>. Higher
> >> +       values enables smaller size at the expense of slower time.
> >
> > s/enables/enable/
> >
> > A couple notes:
> >
> > "slower time" is an unusual way to convey the concept; perhaps say it
> > takes "more time".
> > [...]
> >> +       Supported values are from `-0` (store-only) to `-9` (best ratio).
> >> +       Default is `-6` if isn't specified.
> >
> > s/if isn't/if it isn't/
> > ...or...
> > s/if isn't/if not/
>
> Sounds all sensible.
>
> In summary, perhaps something like this?  I still have "-9 (best
> ratio)" which does not say it is merely the intent and not
> guarantee, but the resulting text read a bit funny with "best ratio"
> replaced with "try hardest".

This version looks fine. Thanks.