From: Eric Sunshine Date: Fri, 01 Mar 2019 18:00:01 GMT Subject: Re: [RFC PATCH 1/4] name-rev: improve name_rev() memory usage Message-ID: In-Reply-To: <20190301175024.17337-2-alban.gruin@gmail.com> On Fri, Mar 1, 2019 at 12:50 PM Alban Gruin wrote: > There a condition that will always be false here when name_rev() calls > itself for the first parent, but it will become useful when name_rev() > will stop to name commits that are not mentionned in the stdin buffer. s/mentionned/mentioned/ > If the current commit should not be named, its parents may have to be, > but they may not. In this case, name_rev() will tell to its caller that s/tell/report/ > the current commit and its first parent has not used the name, and that > it can be released. However, if the current commit has been named but > not its parent, or the reverse, the name will not be released. > > Signed-off-by: Alban Gruin