From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 11 Apr 2025 21:29:13 GMT
Subject: Re: [PATCH v2 1/9] object-file: move `safe_create_leading_directories()` into "dir.c"
Message-ID: <CAPig+cQ5AEwTaK2LYkV39yrZppnF_MMMnB2V0nTGWZ-PcptVYA@mail.gmail.com>
In-Reply-To: <xmqq5xjampdc.fsf@gitster.g>

On Fri, Apr 11, 2025 at 4:10 PM Junio C Hamano <gitster@pobox.com> wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > The `safe_create_leading_directories()` function and its relatives are
> > located in "object-file.c", which is not a good fit as they provide
> > generic functionality not related to objects at all. Move them into
> > "dir.c".
>
> It may be debatable that <dir.c>, which has traditionally been a
> collection of read-only operations (mostly for exclude/ignore
> processing), is a good place to host "mkdir -p", but it certainly is
> better than having it in <object-file.c>

I probably would have expected safe_create_leading_directories() to be
moved to "path.[hc]" which already houses functions such as
safe_create_dir(), normalize_path_copy(), ends_with_path_components(),
longest_ancestor_length(), etc.