From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 12 Sep 2019 14:47:41 GMT
Subject: Re: [PATCH] git-svn: trim leading and trailing whitespaces in author name
Message-ID: <CAPig+cQ53m0LrmScKnrcddyQzBRw_P=74cJ_H51GGrs8FD4RRg@mail.gmail.com>
In-Reply-To: <20190912115201.888-1-tklauser@distanz.ch>

On Thu, Sep 12, 2019 at 7:59 AM Tobias Klauser <tklauser@distanz.ch> wrote:
> In some cases, the svn author names might contain leading or trailing
> whitespaces, leading to messages such as:
>
>   Author: user1
>    not defined in authors.txt
>
> (the trailing newline leads to the line break). The user "user1" is
> defined in authors.txt though, e.g.
>
>   user1 = User <user1@example.com>
>
> Fix this by trimming the author name retreived from svn before using it
> in check_author.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
> @@ -1491,6 +1491,7 @@ sub call_authors_prog {
>  sub check_author {
>         my ($author) = @_;
> +       $author =~ s/^\s+|\s+$//g;
>         if (!defined $author || length $author == 0) {
>                 $author = '(no author)';
>         }

This fix seems incomplete. What happens if $author is undefined?
(There is a check for $author defined'ness just below the new code you
add.)