From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 16 May 2016 23:45:13 GMT
Subject: Re: [PATCH v2 02/12] attr.c: use strchrnul() to scan for one line
Message-ID: <CAPc5daXz59fX6MGfmAZ31GR_=Ph=_zZY35W4vfXkD1noK571dg@mail.gmail.com>
In-Reply-To: <CAGZ79kbSFp5e6-AeSbqk4hFxcuzTo-4oSG_z5nGTpAY0uvLAuw@mail.gmail.com>

On Mon, May 16, 2016 at 4:28 PM, Stefan Beller <sbeller@google.com> wrote:
>>         for (sp = buf; *sp; ) {
>>                 char *ep;
>>                 int more;
>> -               for (ep = sp; *ep && *ep != '\n'; ep++)
>> -                       ;
>> +
>> +               ep = strchrnul(sp, '\n');
>
> (Even lesser nit as in patch 1)
> You could directly assign ep and more when declaring them.

I'd prefer not to.

"A declaration block, blank and statement" pattern allows you
to have the declaration of variables to group related things
together and in an order that makes it easier to explain.
If you throw in initialization there, you cannot do that anymore
(e.g. ep must be initialized before you can compute more).