From: Junio C Hamano Date: Mon, 15 Jun 2015 19:48:02 GMT Subject: Re: [PATCH v2 12/12] refs: move the remaining ref module declarations to refs.h Message-ID: In-Reply-To: <20150615183504.GB4041@peff.net> On Mon, Jun 15, 2015 at 11:35 AM, Jeff King wrote: > > I think the real benefit of naming parameters is that you can talk about > "fn" and "cb_data" by name in the docstring[1]. Yes, I would think it is a very sensible thing to do, if a patch that adds docstring adds names so that the documentation can refer to them. But otherwise, the patch presented here adds only noise without adding much value.