From: Junio C Hamano Date: Mon, 06 Oct 2014 19:28:55 GMT Subject: Re: [PATCH/RFC 5/5] add tests for checking the behaviour of "unset.variable" Message-ID: In-Reply-To: <5432E67B.8070604@gmail.com> On Mon, Oct 6, 2014 at 11:59 AM, Tanay Abhra wrote: > 3> Special case "unset.variable", so that git config unset.variable foo.baz > pastes it on the top of the file. The implementation should be trivial, but, > Junio had said in an earlier mail that he doesn't think this approach would > do much good. > > Other than this approach, Junio had suggested to append it after the last mention > of "foo.baz",... Just to make sure there is no misunderstanding. "it" in "append it" above does not refer to unset.variable, and "the last mention of "foo.baz"" is not "[foo]baz=value" The point is to prevent"git config --add foo.baz anothervalue" starting from --- --- --- [foo] bar = some [unset] variable = foo.baz --- --- --- from adding foo.baz next to existing foo.bar. We would want to end up with --- --- --- [foo] bar = some [unset] variable = foo.baz [foo] baz = anothervalue --- --- --- So "When dealing with foo.baz, ignore everything above the last unset.variable that unsets foo.baz" is what I meant (and I think that is how I wrote).