From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 Aug 2015 20:20:15 GMT
Subject: Re: [PATCH v2 13/16] lock_repo_for_gc(): compute the path to "gc.pid" only once
Message-ID: <CAPc5daXW-uP+3t+7fXvhyb9TkyeTJL9=Phc9PJJ-iwr4uyfS_w@mail.gmail.com>
In-Reply-To: <xmqq4mk5r3nf.fsf@gitster.dls.corp.google.com>

On Tue, Aug 11, 2015 at 1:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> Looks correct; somehow this reminded me of the other topic from Peff
> to reduce use of git_path() ;-)
>
>> -     pidfile = git_pathdup("gc.pid");
>> +     pidfile = pidfile_path;
>>       sigchain_push_common(remove_pidfile_on_signal);
>>       atexit(remove_pidfile);
>
> I wonder if you can reduce the atexit() here by registering this as
> a tempfile to be cleared?

Heh, I should have been slightly more patient. That is what 14/16 is about ;-)