From: Junio C Hamano Date: Wed, 27 Jul 2016 21:28:32 GMT Subject: Re: [PATCH 1/2] pack-objects: break out of want_object loop early Message-ID: In-Reply-To: <20160727211338.GA20608@sigill.intra.peff.net> On Wed, Jul 27, 2016 at 2:13 PM, Jeff King wrote: > ... But two is that I've > wondered if we can do even better with a most-recently-used cache > instead of the last_pack_found hack. So I'm trying to implement and > measure that (both for this loop, and to see if it does better in > find_pack_entry). It is always delightful to hear a well constructed description of a thought process. Thanks. One thing that made me wonder was what would happen to the last_found that is static to has_sha1_pack_kept_or_nonlocal() funciton, when we invalidate the packed_git list, but within the context of pack-objects it is not likely?