From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Sep 2015 19:18:50 GMT
Subject: Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs
Message-ID: <CAPc5daWiACH6fVDyszdRBAs0aHg1wUi7wjKfH7VKu=TVK6dBtg@mail.gmail.com>
In-Reply-To: <CAOLa=ZS5bM_h7CLJD+Nj1h1qi3FCfjVYX0ZBGCX6PDXt+9XQyw@mail.gmail.com>

Ehh, I was only kidding, though...

On Wed, Sep 9, 2015 at 10:37 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
> On Tue, Sep 8, 2015 at 11:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>>>> This line still looks overlong.  Would it help to stop spelling this
>>>>> as a double "a = b = overlong expression" assignment?
>>>>>
>>>>
>>>> I'm not sure, I get what you mean.
>>>
>>> I guess
>>>
>>> format = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) %%(contents:lines=%d)",
>>>                  filter->lines);
>>> to_free = format;
>>>
>>> (still 83 columns + indentation, but that's a bit shorter than your
>>> version).
>>
>> Sure.  This may also be possible
>>
>>         xstrfmt("%s %%(contents:lines=%d)",
>>                 "%(align:15,left)%(refname:short)%(end)", filter->lines);
>>
>> and highlights that the only thing that is variable is the number
>> of lines, which might be better.
>
> Yeah looks better, thanks.
>
> --
> Regards,
> Karthik Nayak