From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 20 Apr 2016 20:07:54 GMT
Subject: Re: [PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable
Message-ID: <CAPc5daWhDToqoeeGrhzjVuDgNu1ar0RvF10iKpH-61yj=z6fVQ@mail.gmail.com>
In-Reply-To: <5717DEEC.4000903@ramsayjones.plus.com>

On Wed, Apr 20, 2016 at 12:56 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>>> +void curl_dump(const char *text, unsigned char *ptr, size_t size, char nohex)
>>> +{
>>> +    size_t i;
>>> +    size_t w;
>
> As I said in a previous email, curl_dump() should be marked
> static here (and remove the declaration from http.h). Unless,
> of course, there are plans for future use/calls being added?

Good point. Thanks.