From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 22 Aug 2014 04:20:49 GMT
Subject: Re: [PATCH 18/18] signed push: final protocol update
Message-ID: <CAPc5daVnhEDykmM6CmZa5q4FWfxuKfqwm0U9vsr7xd3sDJSboQ@mail.gmail.com>
In-Reply-To: <CAJo=hJuToRQDTkccV9BfVbs1YnjCrr2iPrG-HmTbJ=ds4r6MzA@mail.gmail.com>

On Thu, Aug 21, 2014 at 12:28 PM, Shawn Pearce <spearce@spearce.org> wrote:
> On Tue, Aug 19, 2014 at 3:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> +  push-cert         = PKT-LINE("push-cert" NUL capability-list LF)
>
> Haha. NUL.  I love our wire protocol.

It is a direct and natural consequence of [PATCH 02/18].

We could use SP here, if we really wanted to, but that would make the
push-cert packet a special kind that is different from others, which we
would want to avoid. "shallow" is already special in that it cannot even
carry the feature request, and it is not worth introducing and advertising
a new capability to fix it, but at least we can avoid making the same
mistake here.