From: Junio C Hamano Date: Thu, 18 Jul 2013 20:54:35 GMT Subject: Re: [PATCH 1/2] git_mkstemps: correctly test return value of open() Message-ID: In-Reply-To: <201307182032.r6IKWtWC016218@freeze.ariadne.com> On Thu, Jul 18, 2013 at 1:32 PM, Dale R. Worley wrote: > I've been looking into writing a proper test for this patch. My first > attempt tests the symptom that was seen initially, that "git commit" > fails if fd 0 is closed. > > One problem is how to arrange for fd 0 to be closed. I could use the > bash redirection "<&-", but I think you want to be more portable than > that. That's just a plain-vanilla part of POSIX shell behaviour, no? http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_05