From: Junio C Hamano Date: Wed, 25 May 2016 00:55:02 GMT Subject: Re: [PATCH] format_commit_message: honor `color=auto` for `%C(auto)` Message-ID: In-Reply-To: <20160524194814.GA12479@zoidberg> On Tue, May 24, 2016 at 12:48 PM, Edward Thomson wrote: > Check that we are configured to display colors in the given context when > the user specifies a format string of `%C(auto)`, instead of always > displaying the default color for the given context. This makes > `%C(auto)` obey the `color=auto` setting and brings its behavior in line > with the behavior of `%C(auto,)`. > > This allows the user the ability to specify that color should be > displayed for a string only when the output is a tty, and to use the > default color for the given context without having to hardcode a > color value. > --- > pretty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks obviously the right thing to do from a cursory read. Missing sign-off? Thanks.