From: Junio C Hamano Date: Mon, 08 Jun 2015 22:32:46 GMT Subject: Re: [PATCHv2 3/3] git-p4: fixing --changes-block-size handling Message-ID: In-Reply-To: <5575E264.6040601@diamand.org> On Mon, Jun 8, 2015 at 11:43 AM, Luke Diamand wrote: > On 08/06/15 18:18, Junio C Hamano wrote: >> >> Lex Spoon writes: >> >>> Precisely, Junio, that's what I had in mind. The patch with the two >>> lines deleted LGTM. >> >> >> Thanks, will do. > > > I don't think we're quite there yet unfortunately. > > The current version of git-p4 will let you do things like: > > $ git p4 clone //depot@1,2015/05/31 > > i.e. get all the revisions between revision 1 and the end of last month. > > Because my change tries to batch up the revisions, it fails when presented > with this. > > There aren't any test cases for this, but it's documented (briefly) in the > manual page. > > I think that although the current code looks really nice and clean, it's > going to have to pick up a bit more complexity to handle non-numerical > revisions. I don't think it's possible to do batching at the same time. > > It shouldn't be too hard though; I'll look at it later this week. [jch: adding git@ back] Thanks.