From: Carlo Arenas <carenas@gmail.com>
Date: Fri, 24 Sep 2021 04:53:54 GMT
Subject: Re: [PATCH v5 3/3] send-email docs: add format-patch options
Message-ID: <CAPUEspjxYy4GOABXkzRza-wmKnZAdq-v=OP-9+-wfV2PCnDGwQ@mail.gmail.com>
In-Reply-To: <9a60226c-7a35-0486-a687-31f7691e7551@gmail.com>

On Thu, Sep 23, 2021 at 9:36 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 24/09/21 09.46, Thiago Perrotta wrote:
> >   SYNOPSIS
> >   --------
> >   [verse]
> > -'git send-email' [<options>] <file|directory|rev-list options>...
> > +'git send-email' [<options>] <file|directory>...
> > +'git send-email' [<options>] <format-patch options>
> >   'git send-email' --dump-aliases
>
> Is <format-patch options> optional? If so, we can say [<format-patch
> options>].

no; as Junio explained [1] this omission is intentional while the
rev-list options that
got cut to make space are not and are more relevant.

IMHO leaving [<options>] to imply ALL options (that also include diff
options, for example) is better

Carlo

[1] https://lore.kernel.org/git/xmqqh7fjuaar.fsf@gitster.g/