From: Carlo Arenas <carenas@gmail.com>
Date: Thu, 20 Jan 2022 02:43:57 GMT
Subject: Re: [PATCH] cache.h: auto-detect if zlib has uncompress2()
Message-ID: <CAPUEspjtz6KjWzyVGYCzqmh2n-_BmTi3TceY6qquuXNeq87JHg@mail.gmail.com>
In-Reply-To: <5c65baaa-ad51-e7e3-c811-1860edb7fff4@web.de>

On Mon, Jan 17, 2022 at 11:49 AM René Scharfe <l.s.r@web.de> wrote:
>
> Am 17.01.22 um 18:13 schrieb Ævar Arnfjörð Bjarmason:
> > diff --git a/compat/zlib-uncompress2.c b/compat/zlib-uncompress2.c
> > index 722610b9718..915796e85ac 100644
> > --- a/compat/zlib-uncompress2.c
> > +++ b/compat/zlib-uncompress2.c
> > @@ -8,15 +8,12 @@
> >
> >  */
> >
> > -#include "../reftable/system.h"
> > -#define z_const
>
> Why is it safe to remove this definition?
> Because it's defined in
> zconf.h, included by zlib.h.  But why did we need it in the first place?

because really old versions of zlib don't have it defined in zconf.h,
and therefore the "compat" code would fail to build.

Carlo