From: Carlo Arenas <carenas@gmail.com>
Date: Thu, 03 Sep 2020 18:55:04 GMT
Subject: Re: Aborting git rebase --edit-todo
Message-ID: <CAPUEspjKcQgLvVrJ2GroqYydNPksEziMgyceN-CFBFVgtngMuA@mail.gmail.com>
In-Reply-To: <xmqqa6y6ah8h.fsf@gitster.c.googlers.com>

On Thu, Sep 3, 2020 at 10:47 AM Junio C Hamano <gitster@pobox.com> wrote:

> Now we have the "drop" verb, the latter interpretation becomes
> possible without making it impossible for the user to express the
> former.

and for people that would like to enforce the use of the drop verb
there is configuration that prevents deleted lines to "silently"
dropping commits since 5a5445d878 (rebase-interactive: warn if commit
is dropped with `rebase --edit-todo', 2020-01-28) :

  rebase.missingCommitsCheck

AFAIK the correct "signal" to abort is to instruct your editor to exit
with non zero (ex: in vi using <esc>:cq), but agree it could be
confusing or "inconsistent" and might be worth adding it a message at
the footer

Carlo