From: Carlo Arenas <carenas@gmail.com>
Date: Fri, 19 Nov 2021 09:36:49 GMT
Subject: Re: [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2
Message-ID: <CAPUEspic-qgLWGgcJeO52A1XeUh7p+F_WKfH0NLYMmMRWL7Cnw@mail.gmail.com>
In-Reply-To: <20211119072357.oxl5caye742blz5j@glandium.org>

On Thu, Nov 18, 2021 at 11:24 PM Mike Hommey <mh@glandium.org> wrote:
>
> The ifdef around gmtime_r and localtime_r in mingw.h is for __MINGW64_VERSION_MAJOR.
> The ifdef around _POSIX_C_SOURCE in git-compat-util.h is for
> __MINGW64__.
> I'd imagine that plays a role.

Must be, and indeed you are right that my 32-bit compiler doesn't set
__MINGW64__ (only __MINGW32__) and I am not hitting that codepath, but
I have no problem building and it seems it is because
_POSIX_THREAD_SAFE_FUNCTIONS it is defined unconditionally at the end
of pthread_unistd.h, unlike what is done for x86_64.

somehow your version of headers might had that removed in both, and
that was "fixed" later.  I have 6346 in i386 and 6306 in x86_64.

Carlo