From: Carlo Arenas Date: Mon, 13 Sep 2021 07:13:50 GMT Subject: Re: [PATCH 1/3] t0301: fixes for windows compatibility Message-ID: In-Reply-To: <0606160d-1192-2074-b1ad-9c5d86c953d5@gmail.com> On Sun, Sep 12, 2021 at 10:34 PM Bagas Sanjaya wrote: > On 13/09/21 03.28, Carlo Marcelo Arenas Belón wrote: > > test -S is not able to detect that a file is a socket, so use > > test -f instead. > > Isn't test -f just check for socket as regular file? and that is exactly how they look; ironically a -f check in Linux fails for sockets so maybe better to do -e? an empty file with nothing that indicates in Windows Explorer or a stat call (from WSL or git bash), that they are anything else. Carlo