From: Carlo Arenas <carenas@gmail.com>
Date: Thu, 21 Apr 2022 19:05:20 GMT
Subject: Re: [PATCH v2] CI: select CC based on CC_PACKAGE (again)
Message-ID: <CAPUEspggNfra_C8PBcVqjZrxxnswg27WFLg2kT6JOCMB8f0FGg@mail.gmail.com>
In-Reply-To: <patch-v2-1.1-92acf9420a9-20220421T174733Z-avarab@gmail.com>

On Thu, Apr 21, 2022 at 10:48 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> Reported-by: Carlo Arenas <carenas@gmail.com>

to avoid confusing the attribution scripts better use my full name:
"Carlo Marcelo Arenas Belón"

> diff --git a/ci/lib.sh b/ci/lib.sh
> index cbc2f8f1caa..86e37da9bc5 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -122,7 +122,7 @@ then
>         test macos != "$CI_OS_NAME" || CI_OS_NAME=osx
>         CI_REPO_SLUG="$GITHUB_REPOSITORY"
>         CI_JOB_ID="$GITHUB_RUN_ID"
> -       CC="${CC:-gcc}"
> +       CC="${CC_PACKAGE:-${CC:-gcc}}"

minor nitpick, but most likely still relevant considering your other
"bashism" fixes.
the POSIX syntax doesn't use ":" (documented in CodingGuidelines)

not sure if the compounded assignment is valid in POSIX, but at least
the following worked with a recent NetBSD 8 sh :

  CC="${CC_PACKAGE-${CC-gcc}}"

Carlo